Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] starship: add patch for CVE-2024-41815 #337567

Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 26, 2024

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2024-41815

Added tests pass.

Already addressed in unstable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 26, 2024
@risicle risicle changed the title starship: add patch for CVE-2024-41815 [24.05] starship: add patch for CVE-2024-41815 Aug 26, 2024
@risicle risicle marked this pull request as ready for review August 26, 2024 22:30
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change and the upstream patch look fine. It builds and works as expected, I cannot reproduce the POC anymore.

Result of nixpkgs-review pr 337567 run on x86_64-linux 1

1 package built:
  • starship

@LeSuisse LeSuisse merged commit 680c1ff into NixOS:release-24.05 Aug 30, 2024
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants